[compiler] Support for member expression inc/decrement #30697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: Builds support for a.x++ and friends. Similar to a.x += y, emits it as an assignment expression. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
+2442
to
+2448
| return { | ||
| kind: 'LoadLocal', | ||
| place: expr.node.prefix | ||
| ? {...newValuePlace} | ||
| : {...previousValuePlace}, | ||
| loc: exprLoc, | ||
| }; |
Member
There was a problem hiding this comment.
This should be fine, but we try to avoid using lvalues more than once. The main exception is for method calls, where we evaluate the receiver to an lvalue, then use that lvalue to load the property for the method and again as the receiver of the method call instruction.
To test, can you add some fixtures where the increment/decrement is used as an rvalue? let x = obj.x++ and (obj.x++).toString()
josephsavona
approved these changes
Aug 15, 2024
Member
josephsavona
left a comment
josephsavona
left a comment
There was a problem hiding this comment.
Awesome! Please see comments before landing with some additional things to test
Test Plan: Builds support for a.x++ and friends. Similar to a.x += y, emits it as an assignment expression. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Test Plan:
Builds support for a.x++ and friends. Similar to a.x += y, emits it as an assignment expression.